Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate bento supported versions within ExtensionSpec #35756

Closed
honeybadgerdontcare opened this issue Aug 20, 2021 · 0 comments · Fixed by #35757
Closed

Indicate bento supported versions within ExtensionSpec #35756

honeybadgerdontcare opened this issue Aug 20, 2021 · 0 comments · Fixed by #35757

Comments

@honeybadgerdontcare
Copy link
Contributor

Description

The AMP-WP plugin using the Optimizer auto imports extension script tags and needs assistance in knowing which version to include; original or Bento.

To assist in this, the ExtensionSpec will have a new field bento_supported_version which will list the versions that are usable for Bento.

Alternatives Considered

bundles.config.extensions.json contains some metadata but it is not sufficient. It is possible to use requires and satisfies logic from the protoascii but that is overly complex and may be error prone from other uses of requires and satisfies.

Additional Context

The issue came to a head when amp-facebook 1.0 was introduced with a different requires_extension. This allows for amp-facebook-comments to be included as a tag and determining which script extension tag to include is not immediately apparent (0.1 or 1.0). More background see comments starting here.

@westonruter @caroqliu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants