Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amp-ad tests to not make network requests to actual ads. #3616

Closed
cramforce opened this issue Jun 16, 2016 · 0 comments
Closed

Fix amp-ad tests to not make network requests to actual ads. #3616

cramforce opened this issue Jun 16, 2016 · 0 comments
Assignees
@muxin
Labels
Related to: Flaky Tests
Milestone
Fixit Week February

Comments

@cramforce
Copy link
Member

I believe we render a lot of a9 ads.

One way would be to use the fake type _ping_.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muxin muxin

Labels
Related to: Flaky Tests
Projects
None yet
Milestone
Fixit Week February
Development

No branches or pull requests
2 participants
@cramforce @muxin