Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-ad set to sticky=top does not reappear after being auto-hidden #36880

Open
trivedi opened this issue Nov 10, 2021 · 1 comment
Open

amp-ad set to sticky=top does not reappear after being auto-hidden #36880

trivedi opened this issue Nov 10, 2021 · 1 comment
Labels
Stale Inactive for one year or more Type: Bug

Comments

@trivedi
Copy link

trivedi commented Nov 10, 2021

Description

For an amp-ad, if we set the sticky attribute to "top", the intended behavior is that once the user scrolls to the top of the viewport, the ad disappears. This was fixed in #36378.

However, after the user scrolls to the top, if they then begin to scrolling down again, I would expect the ad to reappear, but it does not. Is this the intended behavior? It seems that would defeat the purpose of using a sticky ad and would impact revenue if the ad stays permanently hidden.

Reproduction Steps

  1. Create an ad that sticks to the top like so:
    <amp-ad sticky="top" width="320" height="50" type="doubleclick" data-slot="/35096353/amptesting/formats/sticky">

  2. As you start scrolling, see that the ad appears

  3. Scroll back to the top and see that the ad disappears

  4. Start scrolling down again and see that the ad stays hidden

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

@stale
Copy link

stale bot commented Nov 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive for one year or more Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant