Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid URL protocol 'threema:' for attribute 'href' in tag 'a'. #3727

Closed
startef opened this issue Jun 22, 2016 · 4 comments
Closed

Invalid URL protocol 'threema:' for attribute 'href' in tag 'a'. #3727

startef opened this issue Jun 22, 2016 · 4 comments
Assignees
@honeybadgerdontcare
Labels
WG: caching
Milestone
Backlog Bugs

Comments

@startef
Copy link

startef commented Jun 22, 2016

The validator throws the following error when a share link for Threema, an alternativ to WhatsApp, is used on a page:

Invalid URL protocol 'threema:' for attribute 'href' in tag 'a'.

Since "whatsapp:" is allowed, "threema:" should be considered valid as well. After all, it is basically the same thing.

The issue can be reproduced by simply testing the following two links in the validator:

<a href="whatsapp://send?text=https%3A%2F%2Fvalidator.ampproject.org">AMP Validator</a>

<a href="threema://compose?text=https%3A%2F%2Fvalidator.ampproject.org">AMP Validator</a>

The whatsapp: link is fine, the threema: link is throwing the mentioned protocol error.

Cheers,
JP
@startef startef mentioned this issue Jun 22, 2016
Closed
@Gregable
Copy link
Member

@honeybadgerdontcare, can you add this protocol to our url lists where appropriate?

@rudygalfi rudygalfi added this to the Backlog milestone Jun 29, 2016
@Gregable Gregable mentioned this issue Jul 1, 2016
Merged
@Gregable
Copy link
Member

Gregable commented Jul 1, 2016

Resolved. This will be deployed to cdn.ampproject.org next week.

@Gregable Gregable closed this as completed Jul 1, 2016
@Gregable
Copy link
Member

Gregable commented Jul 6, 2016

This change is now live on cdn.ampproject.org

@startef
Copy link
Author

startef commented Jul 6, 2016

Confirmed. Thank you very much!

@startef startef mentioned this issue Apr 21, 2018
Closed
@dreamofabear dreamofabear mentioned this issue Feb 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honeybadgerdontcare honeybadgerdontcare

Labels
WG: caching
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
4 participants
@Gregable @honeybadgerdontcare @rudygalfi @startef