Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bento launch: remove experiment #37364

Open
Tracked by #6831
samouri opened this issue Jan 12, 2022 · 2 comments
Open
Tracked by #6831

Bento launch: remove experiment #37364

samouri opened this issue Jan 12, 2022 · 2 comments
Assignees
Labels
Stale Inactive for one year or more Type: Feature Request WG: bento

Comments

@samouri
Copy link
Member

samouri commented Jan 12, 2022

Description

Now that Bento is launched (https://bentojs.dev), we should remove the bento experiment from all of our AMP Components. One example is:

isLayoutSupported(layout) {
userAssert(
isExperimentOn(this.win, 'bento') ||
isExperimentOn(this.win, 'bento-carousel'),
'expected global "bento" or specific "bento-carousel" experiment to be enabled'
);
return super.isLayoutSupported(layout);
}

If we can't do this today, we should come up with a list of items we need accomplished before we can remove the experiment.

cc @kristoferbaxter

@samouri samouri changed the title Bento Launch: remove experiment Bento launch: remove experiment Jan 12, 2022
@alanorozco alanorozco self-assigned this Jan 12, 2022
@westonruter
Copy link
Member

So far this has been done for amp-wordpress-embed in #37237.

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Inactive for one year or more Type: Feature Request WG: bento
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants