Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double hide/show calls on validation bubble #3782

Closed
mkhatib opened this issue Jun 25, 2016 · 0 comments
Closed

Avoid double hide/show calls on validation bubble #3782

mkhatib opened this issue Jun 25, 2016 · 0 comments

Comments

@mkhatib
Copy link
Contributor

mkhatib commented Jun 25, 2016

This to track avoiding calling hide or show when we're already at the exact same state that we'll end up with after the call. Following up on this PR discussion.

One last: We may end up double calling #hide and #show. Storing the current message as a state on ValidationBubble, we can check if we're already hidden, or if we're trying to show the same message again. In either case, we can return without doing anything.

Yeah we'd also need to store the targetElement and visibility state of the bubble in that state to make sure we're calling show for the same element as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant