Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP-STORY] Adding amp-date-countdown to the amp-story framework #38432

Open
edoudou opened this issue Sep 1, 2022 · 5 comments
Open

[AMP-STORY] Adding amp-date-countdown to the amp-story framework #38432

edoudou opened this issue Sep 1, 2022 · 5 comments

Comments

@edoudou
Copy link
Contributor

edoudou commented Sep 1, 2022

Description

It already exist in amp : https://amp.dev/documentation/components/amp-date-countdown-v1.0/?format=websites

We already had request for this feature, and it fits perfectly the use case of stories.

Alternatives Considered

We could considered coding another countdown specially for stories, but it seems pointless not to use the one that already exist.

Additional Context

No response

@mszylkowski
Copy link
Contributor

More context: amp-date-countdown-0.1 seems to work well when added into a story (so the integration would be easy, we just need to make it valid). It allows you to make a design from a template that contains a countdown in text (which can be styled however you want).

v1.0 I think is still experimental, but v0.1 worked well when I briefly tested it (and it's also smaller in size).

@newmuis
Copy link
Contributor

newmuis commented Sep 2, 2022

I think 1.0 represents the bento version of the component, which is incompatible with stories, but cc @alanorozco to confirm

@edoudou
Copy link
Contributor Author

edoudou commented Sep 5, 2022

I guess the 0.1 version would be enough then.

@newmuis
Copy link
Contributor

newmuis commented Sep 13, 2022

@edoudou would you be able to handle making the validation change? It would involve adding AMP-DATE-COUNTDOWN to the various descendant_tag_list allowlists in validator-amp-story.protoascii

@edoudou
Copy link
Contributor Author

edoudou commented Sep 13, 2022

@edoudou would you be able to handle making the validation change? It would involve adding AMP-DATE-COUNTDOWN to the various descendant_tag_list allowlists in validator-amp-story.protoascii

I can take a look tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants