New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document which (if any) svg attributes are disallowed #496
Comments
This is implemented as a white list, so essentially there are an infinite number of disallowed attributes. That said, there are definitely some that I can think of which we conceptually disallow:
Also xlink:href is allowed if the target starts with '#', so in other words is local to the document. |
Is the white list of attributes too long to list in the docs? If not, please add the list to the docs, and otherwise consider adding a link to the complete set of allowed attributes. |
No, not long. We'll do. |
But my ideal solution would be to merge the validation rules into Github very soon and build docs based on them automatically. This way we'll have rules and docs sync'd 100%. So, I'd prioritize doing that. |
Sounds good to me. |
Is there anything to do here? |
https://github.com/ampproject/amphtml/blob/master/spec/amp-html-format.md#svg
Are there any svg attributes that are disallowed, or handled in a limited way (apart from the already listed "xlink:href")?
The text was updated successfully, but these errors were encountered: