Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show compiler warnings for dangerous use of this #5229

Closed
dreamofabear opened this issue Sep 26, 2016 · 0 comments · Fixed by #5244
Closed

Show compiler warnings for dangerous use of this #5229

dreamofabear opened this issue Sep 26, 2016 · 0 comments · Fixed by #5244
Assignees

Comments

@dreamofabear
Copy link

Property flattening in Closure compiler can cause bugs when using this in non-constructor, non-prototype methods, e.g. this bug due to compiling non-conformant 3P code.

Closure compiler prints warnings for this case that look like this:

"WARNING - dangerous use of this in static method foo.bar"

For some reason, these warnings aren't being displayed during gulp dist -- we should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants