Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Slides carousel: The preloaded slides need aria-hidden #5484

Closed
aghassemi opened this issue Oct 10, 2016 · 2 comments · Fixed by #6295
Closed

[A11Y] Slides carousel: The preloaded slides need aria-hidden #5484

aghassemi opened this issue Oct 10, 2016 · 2 comments · Fixed by #6295
Assignees
@chenshay
Labels
Related to: Accessibility
Projects
A11Y Week
Milestone
To be deprecated ...

Comments

@aghassemi
Copy link
Contributor

SlideScroll preloads the previous and next slides and removes display:none from them (although they are still hidden because of overflowing the parent). Currently a TalkBack user can view all three slides, therefore we need to add aria-hidden to the preloaded slides to hide them.
@aghassemi aghassemi modified the milestone: Fixit - Date TBD Oct 10, 2016
@aghassemi
Copy link
Contributor Author

/to @muxin

@ericlindley-g ericlindley-g added this to the Current milestone Oct 13, 2016
@aghassemi aghassemi assigned chenshay and unassigned muxin Nov 4, 2016
@aghassemi
Copy link
Contributor Author

/to @chenshay Quick a11y issue for when you need a break from the viewer API work.

@chenshay chenshay mentioned this issue Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenshay chenshay

Labels
Related to: Accessibility
Projects
A11Y Week
Done
Milestone
To be deprecated - Current
Development

Successfully merging a pull request may close this issue.

Carousel chenshay/amphtml
4 participants
@chenshay @aghassemi @muxin @ericlindley-g