Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize: Defer amp-lightbox build #5600

Closed
cramforce opened this issue Oct 13, 2016 · 1 comment · Fixed by #5941
Closed

Optimize: Defer amp-lightbox build #5600

cramforce opened this issue Oct 13, 2016 · 1 comment · Fixed by #5941
Assignees
@chenshay
Labels
GFI Candidate Related to: Performance
Milestone
Pending Triage

Comments

@cramforce
Copy link
Member

I think the buildCallback in amp-lightbox can be deferred until it is actually opened.
@ericlindley-g ericlindley-g added this to the Pending Triage milestone Oct 20, 2016
@cramforce
Copy link
Member Author

Over to @chenshay as a starter bug. Happy to talk through this in person.

@chenshay chenshay mentioned this issue Nov 1, 2016
Merged
@aghassemi aghassemi removed this from Done in Claimed by Community Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenshay chenshay

Labels
GFI Candidate Related to: Performance
Projects
None yet
Milestone
Pending Triage
Development

Successfully merging a pull request may close this issue.

Build only first time lightbox is opened chenshay/amphtml
3 participants
@cramforce @chenshay @ericlindley-g