Focus ad blocker breaks loading AMP pages on Google Search

[cramforce]

I received reports about this from users (See https://twitter.com/dwm189/status/797460628344541184 but it might affects other users)

This may, in particular, affect reddit pages, but maybe all pages.

To @choumx for debugging.

[cramforce]

Filed disconnectme/disconnect-tracking-protection#9

[cramforce]

Also filed https://bugzilla.mozilla.org/show_bug.cgi?id=1317067

[dreamofabear]

• Most news publishers unaffected
• All reddit AMP pages broken by Block social trackers setting
• All Forbes AMP pages broken by Block ad trackers setting
• Block other content trackers setting has no apparent effect, despite scary warning

[cramforce]

Gist with info from user https://gist.github.com/dmccown/2a300939844c87a5c2d787ae2a9a607b

[dreamofabear]

I believe the problem is the way Focus builds the URL filtering regex from disconnect's blacklist JSON. Specifically, it creates Swift regexes for blacklisted domains that incorrectly match AMP CDN URLs. I'll add details on the Bugzilla entry that Malte filed above.

[dreamofabear]

PR with my proposed fix: mozilla-mobile/focus-ios#26

[dreamofabear]

/cc @dmccown

[dreamofabear]

PR is merged. Bug should be fixed on the next release of Focus.

[rudygalfi]

This might be happening again based on reports on Reddit. @choumx Do you have any status on when the fix went out (if it went out) and can you check again to see if you can reproduce?

[dreamofabear]

Just tried and can't repro. The fix was released on November 17, 2016. That user may need to update the Firefox Focus app to v2.0+.

[cramforce]

@rudygalfi Apparently it isn't entirely trivial to get focus to update the ruleset. I do not have instructions, though.