Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add bottom-navigation Tag #6887

Closed
jet10000 opened this issue Jan 5, 2017 · 7 comments
Closed

Please add bottom-navigation Tag #6887

jet10000 opened this issue Jan 5, 2017 · 7 comments

Comments

@jet10000
Copy link

jet10000 commented Jan 5, 2017

Please add bottom-navigation Tag

https://material.io/guidelines/components/bottom-navigation.html

@jridgewell
Copy link
Contributor

/to @rudygalfi, @ericlindley-g

@ericlindley-g
Copy link
Contributor

Thanks for getting in touch, @jet10000 — agreed that this is a nice mobile pattern to support.

@camelburrito: I think this basic pattern is already supported in AMP (correct me if there are missing pieces — I know scrolling of fixed elements on iOS has been an issue in the past). If that's the case, @jet10000, you can already build this UI.

However, we could make it easier to build out-of-the-box. This might make sense as a copy/paste HTML+CSS template in AMP Start. WDYT @camelburrito? (someone could even build out a Material theme down the line that includes this)

/cc @abeck000 as FYI

@camelburrito
Copy link
Contributor

@jet10000 you should be totally able to do it on your page with position: fixed. As component does not make any sense if there are only links that we can navigate to. I think this would make total sense if they are implemented as Tabs (@ericlindley-g we should remember this use case when we build amp-tabs)

@ericlindley-g yes we could build a theme that showcases this on AMP start

@ericlindley-g
Copy link
Contributor

@camelburrito Good point on remembering this when building amp-tabs ( /cc @chenshay for visibility)

@adelinamart adelinamart added this to the Pending Triage milestone Jan 18, 2017
@rudygalfi
Copy link
Contributor

@ericlindley-g Can you shift this over to being an Amp By Example or AMP Start issue, and then close this?

@rudygalfi rudygalfi removed their assignment Feb 2, 2017
@camelburrito
Copy link
Contributor

@rudygalfi - may be amp start, probably not worth it in ABE.

@ericlindley-g
Copy link
Contributor

Moved to the AMP Start repo to track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants