Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize rendering 3p ads in AMP #7500

Closed
2 of 3 tasks
jasti opened this issue Feb 11, 2017 · 10 comments
Closed
2 of 3 tasks

Optimize rendering 3p ads in AMP #7500

jasti opened this issue Feb 11, 2017 · 10 comments

Comments

@jasti
Copy link
Contributor

jasti commented Feb 11, 2017

@lannka as discussed, this could be optimized further to remove any voluntary delays for 3P ads.

@jasti jasti added this to the Sprint H2 Feb milestone Feb 11, 2017
@jasti jasti added this to Sprint Candidate in AMP Advertising Feb 11, 2017
@jasti jasti changed the title Optimize rendering amp 3p ads Optimize rendering 3p ads in AMP Feb 14, 2017
@lannka
Copy link
Contributor

lannka commented Feb 16, 2017

I plan to start collecting a new metric to tell us how many times user see blank ad slots.

perceivedAdDelay = Max(adLayoutTime - adFirstInViewportTime, 0);

This value can be significantly affected by the following properties of an ad, so we will want to collect those properties together with the metric.

  • if the ad is above the fold or below the fold
  • 3 different render flows: 3p, A4A preferential rendering, A4A delayed rendering

@cramforce this is what we talked about.

@lannka
Copy link
Contributor

lannka commented Feb 16, 2017

@cramforce what do you think if we introduce the same thing for non ad elements perceivedContentDelay.

Then our optimization goal becomes: minimize the perceivedAdDelay without increasing the perceivedContentDelay.

@cramforce
Copy link
Member

Yes, perfect. Thanks.

@jasti jasti moved this from Sprint Candidate to In Progress in AMP Advertising Feb 22, 2017
@lannka lannka moved this from In Progress to Backlog in AMP Advertising Feb 24, 2017
@jasti jasti modified the milestones: Sprint H1 May, Prioritized FRs Apr 27, 2017
@lannka
Copy link
Contributor

lannka commented May 4, 2017

The metrics and experiment infrastructure is already set up: #7789. We can start to tweak params and run experiment.

Right now, the voluntary delay is from 2 rules:

  1. maximum one ad load per second
  2. no ad load in the first 2 seconds of page visible

We can loosen constraint 1), detailed plan here: #9149.
For 2, this is a default setting of AMP resource scheduling. It was introduced as a penalty time for low priority elements:

delayInMs = priority * 1000

@dvoytenko want to hear from you, if you're comfortable that we start tuning this magic number.

@dvoytenko
Copy link
Contributor

It's fine to experiment with this numbers. Let's just make sure we get the right comparison. What numbers (besides perceivedContentDelay) will we look at? I assume "bad frame probability" and perceivedContentDelay[priority < 2]?

@lannka
Copy link
Contributor

lannka commented May 10, 2017

@dvoytenko yes, you're right

@lannka lannka modified the milestones: Sprint H2 May, Sprint H1 May May 16, 2017
@jasti jasti moved this from Backlog to Feature Backlog in AMP Advertising Jun 1, 2017
@jasti jasti removed this from Feature Backlog in AMP Advertising Jun 1, 2017
@jasti jasti added this to Current Sprint in AMP Advertising Jun 2, 2017
@jasti jasti moved this from Current Sprint to Feature Backlog in AMP Advertising Jun 15, 2017
@lannka lannka moved this from Feature Backlog to Sprint Candidate in AMP Advertising Jul 28, 2017
@jasti jasti moved this from Sprint Candidate to Current Sprint in AMP Advertising Jul 28, 2017
@lannka lannka modified the milestones: Sprint H1 August, Backlog Bugs Aug 7, 2017
@jasti jasti moved this from Current Sprint to Blocked in AMP Advertising Oct 27, 2017
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @lannka Do you have any updates?

2 similar comments
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @lannka Do you have any updates?

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @lannka Do you have any updates?

@lannka lannka removed this from Blocked in AMP Advertising Jul 2, 2019
@lannka lannka added this to Needs triage in Ads & Analytics issue triaging via automation Jul 2, 2019
@lannka
Copy link
Contributor

lannka commented Jul 2, 2019

Closing this as we switched direction to push adoption for fast fetch.

@lannka lannka closed this as completed Jul 2, 2019
Ads & Analytics issue triaging automation moved this from Needs triage to Closed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

6 participants