Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-inabox host window handshake improvements #9120

Closed
lannka opened this issue May 3, 2017 · 0 comments · Fixed by #21208
Closed

amp-inabox host window handshake improvements #9120

lannka opened this issue May 3, 2017 · 0 comments · Fixed by #21208

Comments

@lannka
Copy link
Contributor

lannka commented May 3, 2017

amp-inabox needs to talk to the host page window to access APIs like scroll position. Right now it simply assume the top window is the right window, which might not be always true. E.g.: AMP cache served in Viewer.

Instead, we can broadcast the handshake requests to all ancestor window, and wait for the first respondent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2 participants