-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shall we generate cookie for Ad CID? #9268
Comments
WAI. The id is used for GA and Ads data joining and if there is no analytics tag on the page, Ads doesn't need to send it across. |
Let amp-ad set cookie can potentially increase the linking coverage, imagine user visited pages without amp-analytics first. My understanding is that in non-AMP world, ads tag also write the cookie if it does not exist yet, right? Also, I saw one other ad network is specifying a cookie scope: AMP_ECID_EZOIC which probably was an mis-understanding of this feature. |
And if you read the README, the |
The current feature doesn't support writing a cookie. This could be changed, but the current user doesn't want it. |
Then README is misleading.
|
You mean to add a bullet point:
? |
Or we can fix the behavior. Why don't we just write a cookie if it does not exist. I think it's valuable as ads in 3P frame will have problem to do cookie in safari. Non-related finding: I saw we have 10 networks calling |
I don't have a strong opinion. It would certainly be reasonable to change. |
@rudygalfi @avimehta any opinion on this? The behavior is inconsistent on CDN and pub hosted domain, because on CDN ad network can always get an AdCID, but on pub hosted domain, it relies on a cookie written by amp-analytics, which is not always there. |
This can be restricted to just write cookies for ad networks that are used right (we don't write a 1P cookie for all ad networks unconditionally)? |
we only write cookie if
|
Just started looking into this. I think it is reasonable to write the cookie for ads loaded in a page on pub domains. Note that the pub still needs to load amp-analytics to be able to write cookies. If the pub doesn't load amp-analytics, a client id will not be returned in either viewer or pub origin case. |
Code here and here and here implies that we do not generate cookie for Ad CID. Is it a bug or working as intended?
@avimehta @cramforce @dvoytenko @rudygalfi
The text was updated successfully, but these errors were encountered: