New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net test failures at head when running locally, not due to timeout. #9581

Closed

bradfrizzell opened this issue May 26, 2017 · 9 comments

Assignees

Labels

P2: Soon Related to: Flaky Tests Type: Bug WG: monetization

Projects

Ads & Analytics issue triaging

Milestone

Contributor

bradfrizzell commented May 26, 2017

Currently seeing multiple test failures at head when running locally, in google/a4a/test/test-utils.js due to dev.assert(AMP.AmpAdUIHandler) throwing in amp-a4a.js.

This does not seem to be causing test failures on Travis, however.

@keithwrightbos reproduced.

bradfrizzell added the Related to: Flaky Tests label

bradfrizzell assigned keithwrightbos, bradfrizzell and lannka

Contributor

lannka commented May 26, 2017

I guess it's time to pay off the technical debt. How about we start a test fixit week rewrite all the existing tests into modern describes form?

I can try to do an example.

Contributor Author

bradfrizzell commented May 26, 2017 •

edited

If we are going to do a test fixit, which I am strongly in favor of, I think we should address #8809

adelinamart added WG: monetization P2: Soon Type: Bug labels

adelinamart added this to the Backlog Bugs milestone

Contributor

lannka commented Jul 24, 2017

@bradfrizzell see #10200 #10173 for examples

lannka removed their assignment

Member

ampprojectbot commented Oct 30, 2017

This issue hasn't been updated in awhile. @keithwrightbos Do you have any updates?

4 similar comments

Member

ampprojectbot commented Jan 29, 2018

This issue hasn't been updated in awhile. @keithwrightbos Do you have any updates?

Member

ampprojectbot commented Jun 5, 2018

This issue hasn't been updated in awhile. @keithwrightbos Do you have any updates?

Member

ampprojectbot commented Sep 11, 2018

This issue hasn't been updated in awhile. @keithwrightbos Do you have any updates?

Member

ampprojectbot commented Jan 9, 2019

This issue hasn't been updated in awhile. @keithwrightbos Do you have any updates?

lannka added this to Needs triage in Ads & Analytics issue triaging via automation

Contributor

lannka commented Jul 2, 2019

Closing now since no test flakes observed anymore.

lannka closed this as completed

Ads & Analytics issue triaging automation moved this from Needs triage to Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment