Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-sidebar 1.0][Toolbar] Add support for positioning the toolbar on the top or bottom #9983

Closed
2 tasks
camelburrito opened this issue Jun 16, 2017 · 3 comments

Comments

@camelburrito
Copy link
Contributor

  • Add support for positioning the toolbar on the top or bottom of the page, You will need to compensate the page for the toolbar height since we don't want any part of the page to become inaccessible (hint: use border/padding/margin hacks as needed). IOS might need special compensation (look at old sidebar code.)
  • Make sure this works in the viewer
@torch2424
Copy link
Contributor

Please Note, this will require some UX decisions, as we do not know if this should be placed at the end of the page, or if it is 'position: fixed' at the bottom of the page.

@torch2424
Copy link
Contributor

For UX decisions / Edge cases on fixed vs. static:

Sidebar is already position: fixed by default. So I think we should assume the fixed route. Also, with #9982 , The user would be able to simply target an element in which the toolbar would be placed into. In that case, they are responsible for styling (We would remove our defaults), and could easily place at the bottom of the page statically. This would still fall in line with our original goal of allowing users to create toolbars without having to write duplicate code.

@torch2424
Copy link
Contributor

After UX discussions, we decided that this should be handled by the developer using the target attribute

Made sure to mention this the Amp By Exmaple issue

Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
AMP Sidebar 1.0
Features [Toolbar]
Development

No branches or pull requests

2 participants