Handle object-fit gracefully for older browsers. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an Error being thrown in IE since it does not support object-fit.
cathyxz
approved these changes
Nov 30, 2018
| case null: | ||
| // For browsers that do not support `object-fit`, default to `fill` | ||
| // behavior. | ||
| return getDimensionsForObjectFitFill(containerSize); |
There was a problem hiding this comment.
Should this just also be the default case?
There was a problem hiding this comment.
As discussed off-line, we do not want a default case as the error throwing can be useful if a new object-fit property is added that we do not support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an Error being thrown in IE since it does not support object-fit.