Do not build grow tests for production #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hm. I'm not sure about this approach. I'd like to avoid spreading logic across multiple places. I'd prefer to keep logic out of the package.json instead and move it into the respective gulp tasks. For example, buildForGrowTests should definitely implement source filtering itself.
tharders
force-pushed
the
fix/dont-deploy-test-content-on-prod
branch
from
e70acca
to
ba6f702
Compare
platform/lib/config.js
Outdated
| configureGrow(settings) { | ||
| const options = {}; | ||
| if (settings) { | ||
| Object.assign(options, settings); |
There was a problem hiding this comment.
I find options vs. settings a little confusing 😁
matthiasrohmer
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grow test contents should not be deployed on prod.
We simply exclude the path /tests/ in the grow build.
On staging the files will still be available:
https://amp-dev-staging.appspot.com/tests/examples/import