Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毃 Error: Template failed: [object HTMLTemplateElement] [object HTMLDivElement]: y is not a function. (In 'y(e)', 'y' is null) #44

Closed
ampprojectbot opened this issue Jan 25, 2021 · 4 comments
Labels
wontfix This bug will not be fixed

Comments

@ampprojectbot
Copy link
Member

ampprojectbot commented Jan 25, 2021

Details

Error report: link
First seen: Jan 22, 2021
Frequency: ~ 525/day

Stacktrace

Error: Template failed:  [object HTMLTemplateElement] [object HTMLDivElement]: y is not a function. (In 'y(e)', 'y' is null)
    at element (node_modules/dompurify/src/purify.js:503:31)
    at currentNode (node_modules/dompurify/src/purify.js:837:64)
    at currentNode (node_modules/dompurify/src/purify.js:1186:28)
    at dirty (src/purifier/purifier.js:101:42)
    at extensions/amp-mustache/0.2/amp-mustache.js:158:44
    at render_ (extensions/amp-mustache/0.2/amp-mustache.js:125:26)
    at data (src/service/template-impl.js:88:32)

Notes

@fstanis modified src/purifier/purifier.js:41-117 in #26221 (Jan 10, 2020)
@choumx modified extensions/amp-mustache/0.2/amp-mustache.js:158-158 in #26298 (Jan 10, 2020)
@dvoytenko modified extensions/amp-mustache/0.2/amp-mustache.js:125-138 in #30226 (Sep 16, 2020)
@dvoytenko modified src/service/template-impl.js:88-91 in #3682 (Jun 21, 2016)

Seen in:

  • 01-23 Nightly (0412)

Possible assignees: @dvoytenko, @choumx

/cc @ampproject/release-on-duty

@jridgewell
Copy link

This affects iOS 9 only, and is caused by an change in DOMPurify, which we upgraded in ampproject/amphtml#32090. @dvoytenko Do you think we should downgrade?

@dvoytenko
Copy link

I believe we explicitly do not support iOS9. Is there a strong reason to change that rule?

@jridgewell
Copy link

Yah, I think it's fine to mark as won't fix? Both AMP and DOMPurify don't consider Safari 9 a supported browser.

@dvoytenko
Copy link

I agree

@jridgewell jridgewell added the wontfix This bug will not be fixed label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This bug will not be fixed
Projects
None yet
Development

No branches or pull requests

3 participants