fix: Made use of proper helper method to get parentNode

test: fixed several more MSIE11 tests
cure53 · Dec 17, 2020 · 8e29990 · 8e29990
1 parent 7e3a705
commit 8e29990
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 13 deletions.
diff --git a/dist/purify.cjs.js b/dist/purify.cjs.js
diff --git a/dist/purify.cjs.js.map b/dist/purify.cjs.js.map
diff --git a/dist/purify.es.js b/dist/purify.es.js
diff --git a/dist/purify.es.js.map b/dist/purify.es.js.map
diff --git a/dist/purify.js b/dist/purify.js
diff --git a/dist/purify.js.map b/dist/purify.js.map
diff --git a/dist/purify.min.js b/dist/purify.min.js
diff --git a/dist/purify.min.js.map b/dist/purify.min.js.map
diff --git a/src/purify.js b/src/purify.js
@@ -507,7 +507,7 @@ function createDOMPurify(window = getGlobal()) {
    *  return. Return true otherwise.
    */
   const _checkValidNamespace = function (element) {
-    let parent = element.parentNode;
+    let parent = getParentNode(element);
 
     // In JSDOM, if we're inside shadow DOM, then parentNode
     // can be null. We just simulate parent in this case.

diff --git a/test/fixtures/expect.js b/test/fixtures/expect.js
@@ -1022,7 +1022,7 @@ module.exports = [
           "<svg></svg><p></p><title>&lt;a id=\"</title><img src=\"x\">\"&gt;",
           "<svg><title><a id=\"</title><img src=x onerror=alert()>\"></a></title></svg>",
           "<svg xmlns=\"http://www.w3.org/2000/svg\"><title><a id=\"</title><img src=x onerror=alert()>\"></a></title></svg>",
-          "<svg xmlns=\"http://www.w3.org/2000/svg\" />"
+          "<svg xmlns=\"http://www.w3.org/2000/svg\"><title><a id=\"</title><img src=x onerror=alert()>\"></a></title></title></svg></svg>"
       ]
   }, {
       "title": "Tests against mXSS behavior with MathML in Chrome 77 and alike",
@@ -1042,7 +1042,7 @@ module.exports = [
           "<svg></svg><p></p><img src=\"x\">",
           "<svg><title><template></template></title></svg>",
           "<svg xmlns=\"http://www.w3.org/2000/svg\"><title><template></template></title></svg>",
-          "<svg xmlns=\"http://www.w3.org/2000/svg\" />"
+          "<svg xmlns=\"http://www.w3.org/2000/svg\"><title><template></template></title></title></svg></svg>"
       ]
   }, {
       "title": "Tests against mXSS behavior with MathML Templates in Chrome 77 and alike",

diff --git a/test/test-suite.js b/test/test-suite.js
@@ -1238,7 +1238,7 @@ module.exports = function (DOMPurify, window, tests, xssTests) {
       "<svg></svg><p></p>",
       "<svg><style></style></svg>",
       "<svg xmlns=\"http://www.w3.org/2000/svg\"><style /></svg>",
-      "<svg xmlns=\"http://www.w3.org/2000/svg\" />"
+      "<svg xmlns=\"http://www.w3.org/2000/svg\"><style /></svg></svg>"
     ]);
   });
   QUnit.test('Avoid mXSS in Chrome 77 and above using HTML', function (assert) {
@@ -1251,7 +1251,7 @@ module.exports = function (DOMPurify, window, tests, xssTests) {
       "<svg></svg><p></p>qqq",
       "<svg><title></title></svg>",
       "<svg xmlns=\"http://www.w3.org/2000/svg\"><title /></svg>",
-      "<svg xmlns=\"http://www.w3.org/2000/svg\" />"
+      "<svg xmlns=\"http://www.w3.org/2000/svg\"><title /></svg></svg>"
     ]);
   });
   QUnit.test(