Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Assign a11y reviewers within the team #18

Closed
nainar opened this issue Jun 20, 2019 · 2 comments
Closed

Discussion: Assign a11y reviewers within the team #18

nainar opened this issue Jun 20, 2019 · 2 comments

Comments

@nainar
Copy link
Collaborator

nainar commented Jun 20, 2019

We are the UI and a11y WG, however we have varying levels of proficiency in a11y.

This means that even a PR reviewed by the UI and a11y WG might miss checking for a11y.

I want to suggest assigning a111y reviewers on the WG (and adding folks from the wider AMP community who can review a11y) who must LGTM code that affects a11y.

@kristoferbaxter
Copy link
Contributor

Are we planning to recommend places for people to ramp up on a11y knowledge?

@nainar
Copy link
Collaborator Author

nainar commented Jun 21, 2019

Is the question for the Working Group of for the general AMP Project?

If latter: We should have a reference page from CONTRIBUTING.md

For the WG, we should be doing more active audits of the components with a11y experts to help upscale knowledge.

cc @sparhami who suggested this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants