New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nextElementSibling and previousElementSibling #1132
Conversation
src/worker-thread/dom/Element.ts
Outdated
* Returns the Element immediately prior to the specified one in its parent's children list, | ||
* or null if the specified element is the first one in the list. | ||
*/ | ||
get previousElementSibling() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to be implemented on CharacterData
for Text
nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised Text Nodes support this. Done
Thank you for the reviews @jridgewell and @rcebulko!! 🎉 |
Use case: amp-carousel's buildDom