Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: fix clear and removeItem #1136

Merged
merged 7 commits into from
Feb 28, 2022
Merged

Storage: fix clear and removeItem #1136

merged 7 commits into from
Feb 28, 2022

Commits on Feb 22, 2022

  1. Storage: fix clear and removeItem

    The mutations array usually contains an index into StringContext for
    value of key/value in the operation. Historically, "delete" was
    modeled as 0th index into the array. Unfortunately, this didn't make
    sense if the first SET op was genuinely referring to the 0th string
    value (See #1035).
    
    While this fixed the first get/set operation, it also meant that deletes
    were no longer possible! This PR now models the delete operation as a -1
    in the unsigned mutation array, corresponding to 2^16-1.
    samouri committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    bb9bc20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ecca0cf View commit details
    Browse the repository at this point in the history
  3. dont rely on overflow

    samouri committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    3946843 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Configuration menu
    Copy the full SHA
    3ca275e View commit details
    Browse the repository at this point in the history
  2. clean up test

    samouri committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    603b270 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Configuration menu
    Copy the full SHA
    a58f111 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. jridgewell found fix

    samouri committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    5f1218e View commit details
    Browse the repository at this point in the history