Merge branch 'chkimes-alloc-unsafe'

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change log for amqplib
 
+## Changes in v0.10.2
+
+    git log v0.10.1..v0.10.2
+
+- Use Buffer.allocUnsafe when sending messages to improve performance ([PR
+  695](https://github.com/amqp-node/amqplib/pull/695), thank you
+  @chkimes and @Uzlopak)
+
 ## Changes in v0.10.1
 
     git log v0.10.0..v0.10.1

lib/connection.js

@@ -560,7 +560,11 @@ C.sendMessage = function(channel,
   var allLen = methodHeaderLen + bodyLen;
 
   if (allLen < SINGLE_CHUNK_THRESHOLD) {
-    var all = Buffer.alloc(allLen);
+    // Use `allocUnsafe` to avoid excessive allocations and CPU usage
+    // from zeroing. The returned Buffer is not zeroed and so must be
+    // completely filled to be used safely.
+    // See https://github.com/amqp-node/amqplib/pull/695
+    var all = Buffer.allocUnsafe(allLen);
     var offset = mframe.copy(all, 0);
     offset += pframe.copy(all, offset);
 
@@ -570,7 +574,11 @@ C.sendMessage = function(channel,
   }
   else {
     if (methodHeaderLen < SINGLE_CHUNK_THRESHOLD) {
-      var both = Buffer.alloc(methodHeaderLen);
+      // Use `allocUnsafe` to avoid excessive allocations and CPU usage
+      // from zeroing. The returned Buffer is not zeroed and so must be
+      // completely filled to be used safely.
+      // See https://github.com/amqp-node/amqplib/pull/695
+      var both = Buffer.allocUnsafe(methodHeaderLen);
       var offset = mframe.copy(both, 0);
       pframe.copy(both, offset);
       buffer.write(both);