Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and install a pkg-config file #577

Closed
wants to merge 1 commit into from

Conversation

acowley
Copy link

@acowley acowley commented Oct 13, 2017

This is a

  • Breaking change
  • New feature
  • Bugfix

I have

@acowley
Copy link
Author

acowley commented Oct 13, 2017

I ran into a need for this while working with easyloggingpp using the nix package manager. I currently generate the .pc file in a nix expression, as pkg-config and cmake work quite nicely together in the nix world, but it would be better if the cmake files of nix users could work outside of the nix environment.

I have not yet updated the CHANGELOG, but would be happy to do so if this new feature is acceptable.

@abumq
Copy link
Owner

abumq commented Oct 15, 2017

looks good, except for the branch, can you please push to develop branch instead? also you can update CHANGELOG if you like.

@acowley acowley changed the base branch from master to develop October 16, 2017 00:59
@acowley
Copy link
Author

acowley commented Oct 16, 2017

I've rebased onto develop and updated CHANGELOG.

@acowley
Copy link
Author

acowley commented Oct 19, 2017

Does this look okay to merge, @abumusamq?

@acowley
Copy link
Author

acowley commented Oct 31, 2017

Another ping to see if we can get this merged.

@acowley
Copy link
Author

acowley commented Nov 20, 2017

Any movement on this?

@abumq
Copy link
Owner

abumq commented Feb 14, 2018

Thanks for this PR @acowley
I have made manual updates (c1b1285). This should be up in next release

@abumq abumq closed this Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants