You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in the templated linear algebra, rhs.H, we use reinterpret_cast to change the array indexing to be 0-based, but the linear algebra routines use is_jacobian_term_used<>(), which checks the 1-based species indices defined in namespace Species, so it appears that we have a issue with the indexing.
I think that we need to offset the indexing in is_jacobian_term_used<>() by 1. Note: this will only affect Strang, since with SDC we always return 1.
This could explain some of the differences seen in #1435
The text was updated successfully, but these errors were encountered:
in the templated linear algebra,
rhs.H
, we usereinterpret_cast
to change the array indexing to be 0-based, but the linear algebra routines useis_jacobian_term_used<>()
, which checks the 1-based species indices defined innamespace Species
, so it appears that we have a issue with the indexing.I think that we need to offset the indexing in
is_jacobian_term_used<>()
by 1. Note: this will only affect Strang, since with SDC we always return 1.This could explain some of the differences seen in #1435
The text was updated successfully, but these errors were encountered: