Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexing issue in is_jacobian_used()? #1499

Closed
zingale opened this issue Mar 3, 2024 · 1 comment
Closed

indexing issue in is_jacobian_used()? #1499

zingale opened this issue Mar 3, 2024 · 1 comment

Comments

@zingale
Copy link
Member

zingale commented Mar 3, 2024

in the templated linear algebra, rhs.H, we use reinterpret_cast to change the array indexing to be 0-based, but the linear algebra routines use is_jacobian_term_used<>(), which checks the 1-based species indices defined in namespace Species, so it appears that we have a issue with the indexing.

I think that we need to offset the indexing in is_jacobian_term_used<>() by 1. Note: this will only affect Strang, since with SDC we always return 1.

This could explain some of the differences seen in #1435

@zingale
Copy link
Member Author

zingale commented Mar 4, 2024

turns out that all of the logic was wrong. See #1502.

@zingale zingale closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant