Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the handling of unicode special characters causing errors in i18n #821

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Fixes the handling of unicode special characters causing errors in i18n #821

merged 2 commits into from
Jul 8, 2019

Conversation

mehtayash
Copy link
Contributor

Fixes #820

@irfn
Copy link

irfn commented Jan 17, 2016

@mehtayash The change is causing some unit tests to fail

@mehtayash
Copy link
Contributor Author

The change has been modified to now successfully take care of the Latin special chars which were ignored previously.

@DanielRuf DanielRuf self-requested a review March 31, 2018 21:03
@amsul amsul merged commit 0fd34ea into amsul:master Jul 8, 2019
@DanielRuf
Copy link
Collaborator

@amsul we should test this with some languages.

Also see #1177

@amsul
Copy link
Owner

amsul commented Jul 16, 2019

@DanielRuf good point.

@mehtayash would you be interested in helping write those tests?

@amsul amsul mentioned this pull request Jul 16, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unicode characters ignored while parsing months string for French and German languages (non-ASCII chars)
4 participants
@mehtayash @irfn @DanielRuf @amsul