Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code dead link #18

Closed
mjstevens777 opened this issue Aug 23, 2018 · 17 comments
Closed

Source code dead link #18

mjstevens777 opened this issue Aug 23, 2018 · 17 comments

Comments

@mjstevens777
Copy link
Contributor

It looks like the original source code download at http://vision.csd.uwo.ca/code/gco-v3.0.zip has moved. I'm not sure if this is a temporary or a permanent issue.

@Borda
Copy link

Borda commented Aug 24, 2018

It seems that all Vision lab's page is down...
just in case, the code is also here - https://github.com/Borda/pyGCO/tree/master/gco_source

@amueller
Copy link
Owner

amueller commented Sep 2, 2018

@Borda do you have written permission by Olga Veksler to redistribute the code or are you breaking the license?

@amueller
Copy link
Owner

amueller commented Sep 2, 2018

It explicitly says "Only Olga Veksler has the right to redistribute this code, unless expressed permission is given otherwise"

@Borda
Copy link

Borda commented Sep 2, 2018

@amueller in such case, I do not have anything like this... :( so could you ask her or shall I try to write her?

@amueller
Copy link
Owner

amueller commented Sep 2, 2018

I was not able to obtain anything, which is why I download it on demand from the website, which is the only legal thing do to (and also possibly kinda sketchy).

@amueller
Copy link
Owner

amueller commented Sep 2, 2018

The copyright is actually with the university, I think, and she can't simply change it.

@Borda
Copy link

Borda commented Sep 3, 2018

I recall that one contributor made a small change in the C code so that is the reason why we have it in the repository...

@amueller
Copy link
Owner

amueller commented Sep 4, 2018 via email

@amueller
Copy link
Owner

amueller commented Sep 4, 2018 via email

@kunal0895
Copy link
Contributor

http://mouse.cs.uwaterloo.ca/code/gco-v3.0.zip

For this zip file, this link worked. Using pip for installing this fails since it refers to the previous link and returns a 404.

@NarayanSchuetz
Copy link
Contributor

It's dead again ;)!

That's why conferences and journals should make it mandatory that code not only be available but be available in a public repository and not some University site that may or may not exist in the next few years to come.

@amueller
Copy link
Owner

I recommend using the OpenGM implementation - at least that was a good idea last time I checked quite a while ago.

@amueller
Copy link
Owner

Well there's a listing here, but it links to the dead link: https://vision.cs.uwaterloo.ca/code/

@Borda
Copy link

Borda commented Aug 11, 2020

I recommend using the OpenGM implementation - at least that was a good idea last time I checked quite a while ago.

do you have an example of a suitable replacement, which function from OpenGM would you recommend?

EDIT: the problem could be similar as they claimed [UNMAINTAINED] OpenGM 2

@NarayanSchuetz
Copy link
Contributor

I don't think OpenGM implements their extended Alpha-Extension / A-B-Swap with label costs.
I mean technically you are allowed to use their source code under their conditions but not allowed to redistribute it.

In the end it's very unlikely that anything would happen as the work most likely was created under employment by the University of Waterloo and thus belongs to them and was meant for non-commercial public access in the first place.

For custom implementations based on min-cuts I had success with this python wrapper based on Vladimir Kolmogorov's C++ source.

@amueller
Copy link
Owner

amueller commented Aug 11, 2020

The alpha-extension and a-b-swap are relatively simple to implement based if you have the graphcuts. Maybe OpenCV would be a suitable implementation?

I also have PyQPBO which is more general (allows non-submodular potentials) but basically as fast as GCO:
https://github.com/pystruct/pyqpbo

It also has an implementation of alpha expansion based on QPBO that's not in the original implementation:
https://github.com/pystruct/pyqpbo/blob/master/src/pyqpbo.pyx#L267

@amueller
Copy link
Owner

fixed in #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants