[MNT] - Update README for list of tested python versions #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks good. |
|
Can you please make sure your original branch is up-to-date? |
|
My fork says it's up to date with |
|
thank you for checking! I'm confused why the test are failing then. But this PR is clearly not the cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README is a bit out of date with the current tested versions, and in the current version implies that the module still is tested on / supports Python2, which I think is no longer the case (?). This update lists the current set of tested Python versions, drawing from the Github actions file.
In addition, there is a minor update to the install section of the README to note that matplotlib is now a required dependency (it previously stated it was optional, but I believe this is outdated).