Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for Arabic #556

Merged
merged 15 commits into from
May 26, 2020
Merged

Add an example for Arabic #556

merged 15 commits into from
May 26, 2020

Conversation

AMR-KELEG
Copy link
Contributor

Adapted from #315

@AMR-KELEG
Copy link
Contributor Author

@amueller Hi Andreas, could you please review and merge the PR into master?
Thanks

@amueller
Copy link
Owner

Thanks, sorry for the delay. Could you say what the text is?
Also weirdly there is no preview for the docs in the CI. Not sure why that is, but looks good and the example seems to be running in sphinx-gallery.

@AMR-KELEG
Copy link
Contributor Author

The text was part of the original PR and it's the Wikipedia article about the Arabic language https://ar.m.wikipedia.org/wiki/%D8%A7%D9%84%D9%84%D8%BA%D8%A9_%D8%A7%D9%84%D8%B9%D8%B1%D8%A8%D9%8A%D8%A9

For the docs preview, I am not sure how can I fix it.

@amueller
Copy link
Owner

Ok great, thanks!

@amueller amueller merged commit 4abc2f7 into amueller:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants