Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgresMetadataExtractor doesn't discover Redshift late binding views #672

Closed
nathanlawrence-asana opened this issue Sep 2, 2020 · 4 comments
Labels
status:completed Issue is completed and on master type:bug An unexpected problem or unintended behavior

Comments

@nathanlawrence-asana
Copy link
Contributor

nathanlawrence-asana commented Sep 2, 2020

Expected Behavior

We're heavy users of late binding views in Redshift (e.g. with no schema binding). I believe that those views should show up in Amundsen (non-late binding views seem to show up just fine), but are not currently showing up in Amundsen.

Possible Solution

The root issue is that views don't actually show up in pg_tables or in the information_schema tables.

The correct way to pull the metadata for these tables is by running the built-in function PG_GET_LATE_BINDING_VIEW_COLS() or by querying against svv_columns (note that unfortunately, neither of these seem to include description metadata).

See amundsen-io/amundsendatabuilder#356 as a possible solution.

Steps to Reproduce

  1. Create a Redshift late binding view
  2. Ingest the Redshift database using the PostgresMetadataExtractor
  3. Verify that the late binding view wasn't ingested

Screenshots (if appropriate)

Context

A number of our late-binding views are very heavily used and so it's important that analysts and data scientists who are using Amundsen can use the tool to look up the table structure.

Your Environment

  • Amunsen version used:
  • Data warehouse stores: Redshift
  • Deployment (k8s or native):
  • Link to your fork or repository:
@jornh
Copy link
Contributor

jornh commented Sep 14, 2020

@nathanlawrence-asana I guess with amundsen-io/amundsendatabuilder#356 merged this issue is resolved, so you can close it?

@nathanlawrence-asana
Copy link
Contributor Author

Yep! Thank you.

@nathanlawrence-asana
Copy link
Contributor Author

@jornh or @feng-tao , do we need to update the Status: label as well? (I don't think I have permissions there).

@feng-tao feng-tao added status:completed Issue is completed and on master and removed status:needs_triage For all issues that need to be processed labels Sep 14, 2020
@feng-tao
Copy link
Member

thanks @nathanlawrence-asana @jornh , label is updated as well.

dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
* fix: fix prog desc in fe when no config is provided

Signed-off-by: feng-tao <fengtao04@gmail.com>

* fix: fix flake8

Signed-off-by: feng-tao <fengtao04@gmail.com>
feng-tao added a commit that referenced this issue May 7, 2021
* fix: fix prog desc in fe when no config is provided

Signed-off-by: feng-tao <fengtao04@gmail.com>

* fix: fix flake8

Signed-off-by: feng-tao <fengtao04@gmail.com>
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
* fix: fix prog desc in fe when no config is provided

Signed-off-by: feng-tao <fengtao04@gmail.com>

* fix: fix flake8

Signed-off-by: feng-tao <fengtao04@gmail.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
* fix: fix prog desc in fe when no config is provided

Signed-off-by: feng-tao <fengtao04@gmail.com>

* fix: fix flake8

Signed-off-by: feng-tao <fengtao04@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:completed Issue is completed and on master type:bug An unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants