Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amundsendatabuilder "leaks" dev dependencies #80

Closed
astahlman opened this issue Aug 14, 2019 · 3 comments
Closed

amundsendatabuilder "leaks" dev dependencies #80

astahlman opened this issue Aug 14, 2019 · 3 comments
Assignees
Labels
status:completed Issue is completed and on master type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements

Comments

@astahlman
Copy link

amundsendatabuilder declares an install_requires dependency on every package from requirements.txt.

This means that all consumers of this package must accept transitive dependencies on the specific versions of every package in amundsendatabuilder's development environment. For example, consumers of amundsendatabuilder are forced to install a specific version of flake8, even though this package doesn't actually need flake8.

Instead, we should declare concrete dependencies needed for development in requirements.txt and put the dependencies needed to install the package in setup.py. See also this SO post for one approach to reduce duplication between the two files: instead of having setup.py read requirements.txt, we can do the opposite and have requirements.txt reference the dependencies in setup.py through the special dot syntax.

@feng-tao
Copy link
Member

cc @verdan

@verdan
Copy link
Member

verdan commented Aug 14, 2019

Agreed! had the same impression when we proposed this solution, as we are installing a lot of test requirements because of this.
The main problem to have the duplicated requirements is like most of the times people introduce the dependencies in one place and forget to do that in other.
This pip install -e things is a nice one, and can also think about this: https://stackoverflow.com/a/20720019

@dschaller dschaller added the keep fresh Disables stalebot from closing an issue label Aug 17, 2019
@feng-tao feng-tao self-assigned this Sep 10, 2019
jakemongaya pushed a commit to jakemongaya/amundsen that referenced this issue Dec 11, 2019
gabrielucelli pushed a commit to gabrielucelli/amundsen that referenced this issue Jan 28, 2020
@Golodhros Golodhros added type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements status:needs_triage For all issues that need to be processed labels May 29, 2020
benrifkind pushed a commit to benrifkind/amundsen that referenced this issue Dec 16, 2020
@feng-tao
Copy link
Member

I think we fix this issue long back.

dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
feng-tao pushed a commit that referenced this issue May 7, 2021
feng-tao pushed a commit that referenced this issue May 7, 2021
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
@Golodhros Golodhros added status:completed Issue is completed and on master and removed keep fresh Disables stalebot from closing an issue status:needs_triage For all issues that need to be processed labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:completed Issue is completed and on master type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements
Projects
None yet
Development

No branches or pull requests

5 participants