Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade flask to 2.2.5 and its related dependencies #2237

Merged
merged 4 commits into from
Mar 6, 2024
Merged

chore: Upgrade flask to 2.2.5 and its related dependencies #2237

merged 4 commits into from
Mar 6, 2024

Conversation

kristenarmes
Copy link
Contributor

@kristenarmes kristenarmes commented Mar 1, 2024 •
edited
Loading

Description

  • Upgrading flask version to 2.2.5, along with some related dependencies.
  • With the later version of werkzeug, I had to update tests that used API calls to pass json instead of data (or instead of nothing) as a param to indicate the expected content type. See release notes from version 2.3.0.

Motivation and Context

We need to upgrade flask due to py3.10 version requirements. This change will also resolve some security dependencies in the project.

How Has This Been Tested?

Ran our frontend, metadata, and search services locally to ensure there were no issues.

Documentation

N/A

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@kristenarmes
Upgrade flask and related dependencies
810a0c1 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added area:common From common folder area:databuilder From databuilder folder area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder labels Mar 1, 2024
@kristenarmes
Fix frontend tests
847f745 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Fixing more tests
eda4217 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes
Revert databuilder version bump, changes don't affect it
cf46352 
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes kristenarmes marked this pull request as ready for review March 2, 2024 01:37
B-T-D
B-T-D approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@B-T-D B-T-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kristenarmes kristenarmes merged commit 125b04f into main Mar 6, 2024
17 checks passed
@kristenarmes kristenarmes deleted the karmes-upgrade-flask-and-deps branch March 6, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B-T-D B-T-D B-T-D approved these changes

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@jinhyukchang jinhyukchang Awaiting requested review from jinhyukchang jinhyukchang is a code owner

@allisonsuarez allisonsuarez Awaiting requested review from allisonsuarez allisonsuarez is a code owner

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@dkunitsk dkunitsk Awaiting requested review from dkunitsk dkunitsk is a code owner

@ozandogrultan ozandogrultan Awaiting requested review from ozandogrultan ozandogrultan is a code owner

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

Assignees
No one assigned
Labels
area:common From common folder area:databuilder From databuilder folder area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristenarmes @B-T-D