Skip to content

Commit

Permalink
fix: hive metadata extractor code lint
Browse files Browse the repository at this point in the history
Signed-off-by: zhmin <myzhmin@gmail.com>
  • Loading branch information
zhmin committed Oct 28, 2020
1 parent e882062 commit ce89331
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions tests/unit/extractor/test_hive_table_metadata_extractor.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def test_extraction_with_empty_query_result(self) -> None:
"""
with patch.object(SQLAlchemyExtractor, '_get_connection'), \
patch.object(HiveTableMetadataExtractor, '_choose_default_sql_stm',
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
extractor = HiveTableMetadataExtractor()
extractor.init(self.conf)

Expand All @@ -39,7 +39,7 @@ def test_extraction_with_empty_query_result(self) -> None:
def test_extraction_with_single_result(self) -> None:
with patch.object(SQLAlchemyExtractor, '_get_connection') as mock_connection, \
patch.object(HiveTableMetadataExtractor, '_choose_default_sql_stm',
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
connection = MagicMock()
mock_connection.return_value = connection
sql_execute = MagicMock()
Expand Down Expand Up @@ -107,7 +107,7 @@ def test_extraction_with_single_result(self) -> None:
def test_extraction_with_multiple_result(self) -> None:
with patch.object(SQLAlchemyExtractor, '_get_connection') as mock_connection, \
patch.object(HiveTableMetadataExtractor, '_choose_default_sql_stm',
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
connection = MagicMock()
mock_connection.return_value = connection
sql_execute = MagicMock()
Expand Down Expand Up @@ -248,7 +248,7 @@ def test_sql_statement(self) -> None:
"""
with patch.object(SQLAlchemyExtractor, '_get_connection'), \
patch.object(HiveTableMetadataExtractor, '_choose_default_sql_stm',
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
extractor = HiveTableMetadataExtractor()
extractor.init(self.conf)
self.assertTrue(self.where_clause_suffix in extractor.sql_stmt)
Expand All @@ -260,7 +260,7 @@ def test_hive_sql_statement_with_custom_sql(self) -> None:
"""
with patch.object(SQLAlchemyExtractor, '_get_connection'), \
patch.object(HiveTableMetadataExtractor, '_choose_default_sql_stm',
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
return_value=HiveTableMetadataExtractor.DEFAULT_SQL_STATEMENT):
config_dict = {
HiveTableMetadataExtractor.WHERE_CLAUSE_SUFFIX_KEY: self.where_clause_suffix,
'extractor.sqlalchemy.{}'.format(SQLAlchemyExtractor.CONN_STRING):
Expand All @@ -276,4 +276,3 @@ def test_hive_sql_statement_with_custom_sql(self) -> None:

if __name__ == '__main__':
unittest.main()

0 comments on commit ce89331

Please sign in to comment.