Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix broken doc link to dashboard_execution model #296

Merged
merged 1 commit into from Jul 17, 2020

Conversation

ccarterlandis
Copy link
Contributor

Summary of Changes

Updated the contents of docs/models.md and fix a malformed link to the implementation of the dashboard_execution model.

Tests

None needed, only updates documentation

Documentation

Updated the contents of docs/models.md and fix a malformed link to the implementation of the dashboard_execution model. I could not find any documentation about how to build the docs locally to test (I assume because you're using GitHub pages) but I tested on my fork and the relative link worked when I followed it through the GitHub UI, whereas it did not before.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@ccarterlandis ccarterlandis changed the title Fix broken doc link to dashboard_execution model fix: Fix broken doc link to dashboard_execution model Jun 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         103      103           
  Lines        4328     4328           
  Branches      403      403           
=======================================
  Hits         3179     3179           
  Misses       1049     1049           
  Partials      100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef5ab6...ff65fc1. Read the comment docs.

@feng-tao
Copy link
Member

feng-tao commented Jun 30, 2020

CLA check fails

@feng-tao
Copy link
Member

feng-tao commented Jul 1, 2020

hey @ccarterlandis , CLA check fails normally just means that you need to config your github email, user name locally before pushing the PR. Thanks for the pr for fixing the issue. Let me know once you update it.

@ccarterlandis
Copy link
Contributor Author

@feng-tao my email and username should have already been configured, I force-pushed to just make sure but the check still seems to be failing. Do I need to sign the CLA here for it to pass?

@feng-tao
Copy link
Member

feng-tao commented Jul 1, 2020

@ccarterlandis I think you need to sign the CLA.

@feng-tao
Copy link
Member

feng-tao commented Jul 6, 2020

@ccarterlandis , have you had the chance to look into the CLA check failure? Thanks.

@ccarterlandis
Copy link
Contributor Author

Hey @feng-tao, I'll take a look soon, sorry it has taken me a while

@feng-tao
Copy link
Member

@ccarterlandis have you had the chance to fix the CLA?

@ccarterlandis
Copy link
Contributor Author

@feng-tao I am still waiting on Gusto's legal team to give me the okay to sign the CLA. It shouldn't be a problem, Gusto simply doesn't have a policy in place yet for this sort of scenario so I wanted to double check with them. As soon as I hear back I'll let you know!

@ccarterlandis
Copy link
Contributor Author

@feng-tao just signed the CLA, let me know if you need anything else!

@feng-tao
Copy link
Member

thanks @ccarterlandis !

@feng-tao feng-tao merged commit 24b3b0a into amundsen-io:master Jul 17, 2020
ccarterlandis added a commit to Gusto/amundsendatabuilder_contrib that referenced this pull request Aug 14, 2020
Signed-off-by: Carter Landis <carter.landis@gusto.com>
jerryzhu2007 pushed a commit to kylg/amundsendatabuilder that referenced this pull request Aug 20, 2020
* commit 'e14b33e776929f8b020f1c6fec75d0fb83687693': (23 commits)
  Fix Athena sample DAG (amundsen-io#341)
  fix: Update postgres_sample_dag to set table extract job as upstream for elastic search publisher (amundsen-io#340)
  chore: mypy cleanup (convert last comment types, remove noqa imports) (amundsen-io#338)
  chore: Convert typings to mypy (amundsen-io#311)
  chore: replace all references of Lyft repo with Amundsen (amundsen-io#323)
  feat: add github actions for databuilder (amundsen-io#336)
  build: fix broken tests in Python 3.7, test in CI (amundsen-io#334)
  fix(deps): Unpin attrs (amundsen-io#332)
  ci: add dependabot config (amundsen-io#330)
  Change repo name in travis file (amundsen-io#324)
  tests: add mock for bigquery auth (amundsen-io#313)
  feat: allow hive sql to be provided as config (amundsen-io#312)
  chore: remove python2 (amundsen-io#310)
  chore: update deps for databuilder (amundsen-io#309)
  fix: cypher statement param issue in Neo4jStalenessRemovalTask (amundsen-io#307)
  fix: Added missing job tag key in hive_sample_dag.py (amundsen-io#308)
  feat: enhance glue extractor (amundsen-io#306)
  fix: Fix sql for missing columns and mysql based dialects (#550) (amundsen-io#305)
  docs: Fix broken doc link to dashboard_execution model (amundsen-io#296)
  chore: apply license headers to all the source files (amundsen-io#304)
  ...

# Conflicts:
#	README.md
#	databuilder/extractor/kafka_source_extractor.py
#	databuilder/publisher/neo4j_csv_publisher.py
#	docs/models.md
#	example/scripts/sample_data_loader.py
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants