chore: replace all references of Lyft repo with Amundsen #323

dorianj · 2020-08-11T23:33:58Z

ref: amundsen-io/amundsen#615

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
- In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
PR includes a summary of changes.
PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
PR passes make test

dorianj · 2020-08-11T23:37:40Z

~~This should either subsume #322, or get merged after that~~ removed the CI stuff from this PR

README.md

markgrover · 2020-08-11T23:45:13Z

README.md

 [![Coverage Status](https://img.shields.io/codecov/c/github/lyft/amundsendatabuilder/master.svg)](https://codecov.io/github/lyft/amundsendatabuilder?branch=master)
 [![License](http://img.shields.io/:license-Apache%202-blue.svg)](LICENSE)
 [![PyPI - Python Version](https://img.shields.io/pypi/pyversions/amundsen-databuilder.svg)](https://pypi.org/project/amundsen-databuilder/)
 [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)](https://img.shields.io/badge/PRs-welcome-brightgreen.svg)
 [![Slack Status](https://img.shields.io/badge/slack-join_chat-white.svg?logo=slack&style=social)](https://amundsenworkspace.slack.com/join/shared_invite/enQtNTk2ODQ1NDU1NDI0LTc3MzQyZmM0ZGFjNzg5MzY1MzJlZTg4YjQ4YTU0ZmMxYWU2MmVlMzhhY2MzMTc1MDg0MzRjNTA4MzRkMGE0Nzk)

-Amundsen Databuilder is a data ingestion library, which is inspired by [Apache Gobblin](https://gobblin.apache.org/). It could be used in an orchestration framework(e.g. Apache Airflow) to build data from Amundsen. You could use the library either with an adhoc python script([example](https://github.com/lyft/amundsendatabuilder/blob/master/example/scripts/sample_data_loader.py)) or inside an Apache Airflow DAG([example](https://github.com/lyft/amundsendatabuilder/blob/master/example/dags/hive_sample_dag.py)).
+Amundsen Databuilder is a data ingestion library, which is inspired by [Apache Gobblin](https://gobblin.apache.org/). It could be used in an orchestration framework(e.g. Apache Airflow) to build data from Amundsen. You could use the library either with an adhoc python script([example](https://github.com/amundsen-io/amundsendatabuilder/blob/master/example/scripts/sample_data_loader.py)) or inside an Apache Airflow DAG([example](https://github.com/amundsen-io/amundsendatabuilder/blob/master/example/dags/hive_sample_dag.py)).

 For information about Amundsen and our other services, visit the [main repository](https://github.com/lyft/amundsen#amundsen) `README.md` . Please also see our instructions for a [quick start](https://github.com/lyft/amundsen/blob/master/docs/installation.md#bootstrap-a-default-version-of-amundsen-using-docker) setup  of Amundsen with dummy data, and an [overview of the architecture](https://github.com/lyft/amundsen/blob/master/docs/architecture.md#architecture).


Looks like this was missed
https://github.com/lyft/amundsen/blob/master/docs/installation.md

Do you know if there are other instances that may have been missed as well? Did you do like a global search? Perhaps you can share the search pattern you used?

i actually just searched for lyft and did most by hand; did this one automated but my cursor was too far down the file when I replaced here

markgrover

Thanks for taking on this chore, Dorian. It's not the most entertaining work but I and the community really appreciate it. Left some comments.

dorianj · 2020-08-12T00:01:24Z

fixed problems

dikshathakur3119 · 2020-08-12T00:15:33Z

example/sample_data/sample_table_programmatic_source.csv

for this project travis-ci build on .org. So I think our travis link is https://travis-ci.org/github/amundsen-io

Thanks Diksha, updated to include that

example/sample_data/sample_user.csv

setup.py

dorianj · 2020-08-12T21:40:55Z

Addressed comments, and rebased to fix tests @markgrover

markgrover · 2020-08-13T19:37:32Z

LGTM, thanks @dorianj

markgrover · 2020-08-13T19:38:27Z

If anyone else has any comments, please comment by EOD today, otherwise I will merge this.

feng-tao · 2020-08-14T03:57:25Z

.travis.yml

@@ -18,4 +18,4 @@ deploy:
  skip_existing: true
  on:
    tags: true
-    repo: amundsen-io/amundsendatabuilder
+    repo: lyft/amundsendatabuilder


why change it back to lyft?

This was in error, I believe because I rebased incorrectly after the other PR changing this landed. Fixed, there are now 0 references to lyft in the repo

codecov-commenter · 2020-08-14T16:28:06Z

Codecov Report

Merging #323 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   74.20%   74.20%           
=======================================
  Files         105      105           
  Lines        4451     4451           
  Branches      405      405           
=======================================
  Hits         3303     3303           
  Misses       1041     1041           
  Partials      107      107

Impacted Files	Coverage Δ
databuilder/extractor/kafka_source_extractor.py	`62.19% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f658d...1338a6d. Read the comment docs.

Signed-off-by: Dorian Johnson <2020@dorianj.net>

dorianj · 2020-08-18T17:51:05Z

Rebased to remove Travis CI conflict, should be g2g @markgrover or @feng-tao

* commit 'e14b33e776929f8b020f1c6fec75d0fb83687693': (23 commits) Fix Athena sample DAG (amundsen-io#341) fix: Update postgres_sample_dag to set table extract job as upstream for elastic search publisher (amundsen-io#340) chore: mypy cleanup (convert last comment types, remove noqa imports) (amundsen-io#338) chore: Convert typings to mypy (amundsen-io#311) chore: replace all references of Lyft repo with Amundsen (amundsen-io#323) feat: add github actions for databuilder (amundsen-io#336) build: fix broken tests in Python 3.7, test in CI (amundsen-io#334) fix(deps): Unpin attrs (amundsen-io#332) ci: add dependabot config (amundsen-io#330) Change repo name in travis file (amundsen-io#324) tests: add mock for bigquery auth (amundsen-io#313) feat: allow hive sql to be provided as config (amundsen-io#312) chore: remove python2 (amundsen-io#310) chore: update deps for databuilder (amundsen-io#309) fix: cypher statement param issue in Neo4jStalenessRemovalTask (amundsen-io#307) fix: Added missing job tag key in hive_sample_dag.py (amundsen-io#308) feat: enhance glue extractor (amundsen-io#306) fix: Fix sql for missing columns and mysql based dialects (#550) (amundsen-io#305) docs: Fix broken doc link to dashboard_execution model (amundsen-io#296) chore: apply license headers to all the source files (amundsen-io#304) ... # Conflicts: # README.md # databuilder/extractor/kafka_source_extractor.py # databuilder/publisher/neo4j_csv_publisher.py # docs/models.md # example/scripts/sample_data_loader.py # setup.py

dorianj mentioned this pull request Aug 11, 2020

[DOCS] Update references to github.com/lyft to be github.com/amundsen-io amundsen-io/amundsen#615

Closed

markgrover reviewed Aug 11, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

markgrover reviewed Aug 11, 2020

View reviewed changes

dikshathakur3119 reviewed Aug 12, 2020

View reviewed changes

jornh reviewed Aug 12, 2020

View reviewed changes

example/sample_data/sample_user.csv Outdated Show resolved Hide resolved

friendtocephalopods reviewed Aug 12, 2020

View reviewed changes

setup.py Outdated Show resolved Hide resolved

dorianj requested a review from markgrover August 13, 2020 16:59

markgrover previously approved these changes Aug 13, 2020

View reviewed changes

feng-tao reviewed Aug 14, 2020

View reviewed changes

dorianj dismissed markgrover’s stale review via 1338a6d August 14, 2020 16:22

chore: replace all references of Lyft repo with Amundsen

08de7b7

Signed-off-by: Dorian Johnson <2020@dorianj.net>

feng-tao approved these changes Aug 18, 2020

View reviewed changes

feng-tao merged commit b5929ce into amundsen-io:master Aug 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: replace all references of Lyft repo with Amundsen #323

chore: replace all references of Lyft repo with Amundsen #323

dorianj commented Aug 11, 2020

dorianj commented Aug 11, 2020 •

edited

markgrover Aug 11, 2020

dorianj Aug 12, 2020

markgrover left a comment

dorianj commented Aug 12, 2020

dikshathakur3119 Aug 12, 2020 •

edited

dorianj Aug 12, 2020

dorianj commented Aug 12, 2020

markgrover commented Aug 13, 2020

markgrover commented Aug 13, 2020

feng-tao Aug 14, 2020

dorianj Aug 14, 2020

codecov-commenter commented Aug 14, 2020

dorianj commented Aug 18, 2020

chore: replace all references of Lyft repo with Amundsen #323

chore: replace all references of Lyft repo with Amundsen #323

Conversation

dorianj commented Aug 11, 2020

Summary of Changes

Tests

Documentation

CheckList

dorianj commented Aug 11, 2020 • edited

markgrover Aug 11, 2020

Choose a reason for hiding this comment

dorianj Aug 12, 2020

Choose a reason for hiding this comment

markgrover left a comment

Choose a reason for hiding this comment

dorianj commented Aug 12, 2020

dikshathakur3119 Aug 12, 2020 • edited

Choose a reason for hiding this comment

dorianj Aug 12, 2020

Choose a reason for hiding this comment

dorianj commented Aug 12, 2020

markgrover commented Aug 13, 2020

markgrover commented Aug 13, 2020

feng-tao Aug 14, 2020

Choose a reason for hiding this comment

dorianj Aug 14, 2020

Choose a reason for hiding this comment

codecov-commenter commented Aug 14, 2020

Codecov Report

dorianj commented Aug 18, 2020

dorianj commented Aug 11, 2020 •

edited

dikshathakur3119 Aug 12, 2020 •

edited