Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing job tag key in hive_sample_dag.py #308

Merged
merged 3 commits into from Jul 28, 2020

Conversation

saiharish97
Copy link
Contributor

@saiharish97 saiharish97 commented Jul 28, 2020

[FIX]

Summary of Changes

Running "create_table_metadata_databuilder_job()" was giving an Exception :
""ConfigMissingException" : No Configuration setting found for key job_publish_tag."
Hence,
Adding a missing key for job_publish_tag in "create_table_metadata_databuilder_job()" of hive_sample_dag.py.

Tests

Ran the modified function and checked neo4j for the graphs. They were being built.

Documentation

None

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Running "create_table_metadata_databuilder_job()" was giving an Exception : 
""ConfigMissingException" : No Configuration setting found for key job_publish_tag."
Hence,
Adding a missing key for job_publish_tag in "create_table_metadata_databuilder_job()" of hive_sample_dag.py.
Made changes to the code as per guidelines
@saiharish97 saiharish97 changed the title Added missing job tag key in hive_sample_dag.py [FIX] Added missing job tag key in hive_sample_dag.py Jul 28, 2020
@saiharish97 saiharish97 changed the title [FIX] Added missing job tag key in hive_sample_dag.py fix: Added missing job tag key in hive_sample_dag.py Jul 28, 2020
Updated the file for failing build
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files         105      105           
  Lines        4492     4492           
  Branches      419      419           
=======================================
  Hits         3338     3338           
  Misses       1049     1049           
  Partials      105      105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa795c...5d7bb79. Read the comment docs.

@feng-tao feng-tao merged commit d6714b7 into amundsen-io:master Jul 28, 2020
@saiharish97 saiharish97 deleted the sai-harish branch July 28, 2020 20:10
ccarterlandis pushed a commit to Gusto/amundsendatabuilder_contrib that referenced this pull request Aug 14, 2020
* Added missing job tag key in hive_sample_dag.py

Running "create_table_metadata_databuilder_job()" was giving an Exception :
""ConfigMissingException" : No Configuration setting found for key job_publish_tag."
Hence,
Adding a missing key for job_publish_tag in "create_table_metadata_databuilder_job()" of hive_sample_dag.py.

* Made changes as per guidelines

Made changes to the code as per guidelines

* Updated the file for failing build

Updated the file for failing build

Signed-off-by: Carter Landis <carter.landis@gusto.com>
jerryzhu2007 pushed a commit to kylg/amundsendatabuilder that referenced this pull request Aug 20, 2020
* commit 'e14b33e776929f8b020f1c6fec75d0fb83687693': (23 commits)
  Fix Athena sample DAG (amundsen-io#341)
  fix: Update postgres_sample_dag to set table extract job as upstream for elastic search publisher (amundsen-io#340)
  chore: mypy cleanup (convert last comment types, remove noqa imports) (amundsen-io#338)
  chore: Convert typings to mypy (amundsen-io#311)
  chore: replace all references of Lyft repo with Amundsen (amundsen-io#323)
  feat: add github actions for databuilder (amundsen-io#336)
  build: fix broken tests in Python 3.7, test in CI (amundsen-io#334)
  fix(deps): Unpin attrs (amundsen-io#332)
  ci: add dependabot config (amundsen-io#330)
  Change repo name in travis file (amundsen-io#324)
  tests: add mock for bigquery auth (amundsen-io#313)
  feat: allow hive sql to be provided as config (amundsen-io#312)
  chore: remove python2 (amundsen-io#310)
  chore: update deps for databuilder (amundsen-io#309)
  fix: cypher statement param issue in Neo4jStalenessRemovalTask (amundsen-io#307)
  fix: Added missing job tag key in hive_sample_dag.py (amundsen-io#308)
  feat: enhance glue extractor (amundsen-io#306)
  fix: Fix sql for missing columns and mysql based dialects (#550) (amundsen-io#305)
  docs: Fix broken doc link to dashboard_execution model (amundsen-io#296)
  chore: apply license headers to all the source files (amundsen-io#304)
  ...

# Conflicts:
#	README.md
#	databuilder/extractor/kafka_source_extractor.py
#	databuilder/publisher/neo4j_csv_publisher.py
#	docs/models.md
#	example/scripts/sample_data_loader.py
#	setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants