Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move grouped_tables into _retrieve_tables() in bigquery_metadata_extractor #430

Merged
merged 1 commit into from Dec 18, 2020

Conversation

xuan616
Copy link
Member

@xuan616 xuan616 commented Dec 18, 2020

Signed-off-by: xuans xuan_shen@outlook.com

Summary of Changes

It is an update for my previous PR(#421) which uses dataset/table_prefix as the key of grouped_tables to solve the table key missing issue since some tables can share the same table_prefix in different datasets. I just noticed the Set self.grouped_tables is only used for a single function _retrieve_tables() in bigquery_metadata_extractor. If so, for fixing that issue, I would like to just move grouped_tables into _retrieve_tables() which only works for a given dataset so that this set can still use table_prefix as the key. It is going to make the code change conciser.

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: xuans <xuan_shen@outlook.com>
@xuan616 xuan616 changed the title Move 'grouped_tables' into _retrieve_tables Move grouped_tables into _retrieve_tables() in bigquery_metadata_extractor Dec 18, 2020
@xuan616 xuan616 changed the title Move grouped_tables into _retrieve_tables() in bigquery_metadata_extractor fix: Move grouped_tables into _retrieve_tables() in bigquery_metadata_extractor Dec 18, 2020
@feng-tao feng-tao merged commit 26a0d0a into amundsen-io:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants