fix: Use dataset_id & table_id as the key of set 'grouped_tables' in bigquery_metadata_extractor #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that some table keys of sharded tables are missing from BQ metadata extractor. Currently, there is a set 'grouped_tables' storing table_prefix of sharded tables to avoid duplicate metadata records, but it is possible the table prefixes would be same in different datasets.
Summary of Changes
Related issue: 833
Sharded tables will use the concatenation of dataset_id & table_id as the key of set 'grouped_tables' in bigquery_metadata_extractor
Tests
No more tests were added and current test can still work
Documentation
More details are in issue 833
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test