Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample dags minor cleanup #344

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Conversation

Alagappan
Copy link
Contributor

Signed-off-by: Alagappan Sethuraman alagappan.als@gmail.com

Summary of Changes

Fixed couple of minor things in Sample Dags - removed unused kwargs params, renamed airflow tasks and set dag structure explicitly

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Alagappan Sethuraman <alagappan.als@gmail.com>
create_table_extract_job = PythonOperator(
task_id='create_table_extract_job',
postgres_table_extract_job = PythonOperator(
task_id='postgres_table_extract_job',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually prefer callable name the same as task_id which is less confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I was just trying to keep it consistent across all example dags. Let me know what is the standard practice within Airflow open source community and I can update the dags to follow the same pattern

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I see other examples do this. Personally I would prefer to keep the same when task_id is short, but I think it is fine to change as well.

@feng-tao feng-tao merged commit 0339dd5 into amundsen-io:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants