Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update SnowflakeMetadataExtractor instructions in readme #353

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

Alagappan
Copy link
Contributor

Signed-off-by: Alagappan Sethuraman alagappan.als@gmail.com

Summary of Changes

Configs for Snowflake metadata extractor was referring postgres metadata extractor. fixed them to have snowflake ones

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Alagappan Sethuraman <alagappan.als@gmail.com>
@Alagappan
Copy link
Contributor Author

cc @feng-tao This should be a quick one. instructions has wrong configs. Fixed them

@Alagappan
Copy link
Contributor Author

@jornh

@feng-tao feng-tao merged commit 39a4316 into amundsen-io:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants