Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updating badges to not be tags #368

Merged
merged 1 commit into from
Sep 21, 2020
Merged

feat: Updating badges to not be tags #368

merged 1 commit into from
Sep 21, 2020

Conversation

allisonsuarez
Copy link
Contributor

Summary of Changes

Updated queries to get Badges rather than Tags with badge type on neo4j.

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

… dashboards rather than badge type tags

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as draft September 17, 2020 18:40
@allisonsuarez allisonsuarez marked this pull request as ready for review September 21, 2020 17:32
@feng-tao
Copy link
Member

lgtm, but I now recall that we have csv file for quick start to show the badge usage ( https://github.com/amundsen-io/amundsendatabuilder/blob/1e01e8c7300088619c8f19f25945eddc5d9433ec/example/sample_data/sample_tags.csv) . I think we need to update that quick start file otherwise it will be broken. It could be done in a different pr, but just FYI.

Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one followup comment

@allisonsuarez allisonsuarez merged commit c196523 into master Sep 21, 2020
@feng-tao feng-tao deleted the asm-badges branch September 21, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants