Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow BigQuery Usage Extractor to extract usage for views #399

Merged
merged 4 commits into from Nov 3, 2020

Conversation

abhinay04
Copy link
Contributor

@abhinay04 abhinay04 commented Nov 2, 2020

Fix for Issue amundsen-io/amundsen#789.

Summary of Changes

Extracts information about views and tables in the BigQuery Usage Extractor

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Abhinay Kathuria <abhinay.kathuria@rea-group.com>

Signed-off-by: Abhinay Kathuria <abhinay@kathuria.com.au>
Signed-off-by: Abhinay Kathuria <abhinay@kathuria.com.au>
Signed-off-by: Abhinay Kathuria <abhinay@kathuria.com.au>

Signed-off-by: Abhinay Kathuria <abhinay@kathuria.com.au>
@abhinay04 abhinay04 force-pushed the bigquery-usage-extractor-fix branch 2 times, most recently from 46e0062 to 9cc8ea5 Compare November 2, 2020 22:18
Signed-off-by: Abhinay Kathuria <abhinay.kathuria@rea-group.com>
@abhinay04 abhinay04 changed the title fix: Allow BigQuery Usage Extractor to extract usage for views [WIP] fix: Allow BigQuery Usage Extractor to extract usage for views Nov 2, 2020
Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feng-tao feng-tao merged commit 8779229 into amundsen-io:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants