Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add databuilder missing dependencies #400

Merged
merged 2 commits into from Nov 3, 2020

Conversation

hhobson
Copy link
Contributor

@hhobson hhobson commented Nov 3, 2020

Summary of Changes

databuilder version 4.0.2 has missing dependencies, causing ModuleNotFoundError when importing databuilder/publisher/neo4j_csv_publisher.py. See Issue #793.

Have added Jinja2>=2.10.0,<2.12 and pandas>=0.21.0,<1.2.0 to setup.py, package versions taken from requirements.txt.

Tests

No test added as only changed setup.py

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: hhobson <hugo.hobson@dazn.com>
Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, we update the requirements.txt, but forgot we no longer import that file in setup.py

@feng-tao feng-tao merged commit 6718396 into amundsen-io:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants