Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update DashboardMetadata docs #402

Merged
merged 2 commits into from Nov 4, 2020
Merged

docs: Update DashboardMetadata docs #402

merged 2 commits into from Nov 4, 2020

Conversation

Spacerat
Copy link
Contributor

@Spacerat Spacerat commented Nov 3, 2020

I noticed that the DashboardMetadata docs are outdated, and reference e.g. 'lastreloadtime' which no longer exists, and is instead implemented in a separate model.

This updates the docs to reflect the current state of Dashboard metadata.

Signed-off-by: Joseph Atkins-Turkish <jatkins-turkish@brex.com>
@feng-tao
Copy link
Member

feng-tao commented Nov 3, 2020

flake8 .
/opt/hostedtoolcache/Python/3.7.9/x64/lib/python3.7/site-packages/pycodestyle.py:113: FutureWarning: Possible nested set at position 1
  EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
./databuilder/models/dashboard/dashboard_metadata.py:23: [W293] blank line contains whitespace

a flake8 error

@feng-tao
Copy link
Member

feng-tao commented Nov 3, 2020

thanks @Spacerat !

@feng-tao feng-tao merged commit 093b3d6 into amundsen-io:master Nov 4, 2020
@Spacerat
Copy link
Contributor Author

Spacerat commented Nov 4, 2020

for sure! and thanks for fixing the lint error :)

@Spacerat Spacerat deleted the patch-1 branch November 4, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants