fix: add csv badges back in Quickstart #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jornh <jornhansen@gmail.com>
jornh
requested review from
allisonsuarez,
dikshathakur3119,
feng-tao,
jinhyukchang and
a team
as code owners
Signed-off-by: jornh <jornhansen@gmail.com>
Signed-off-by: jornh <jornhansen@gmail.com>
Signed-off-by: jornh <jornhansen@gmail.com>
…sendatabuilder into jornh-fix-csv-badges Signed-off-by: jornh <jornhansen@gmail.com>
jornh
force-pushed
the
jornh-fix-csv-badges
branch
from
793a4ff
to
64c7164
Compare
|
@allisonsuarez ready for review. I notice you have started work on an alternative PR - sorry I wasn't able to complete this sooner, so you could have saved some cycles. |
Signed-off-by: jornh <jornhansen@gmail.com>
Signed-off-by: jornh <jornhansen@gmail.com>
jornh
force-pushed
the
jornh-fix-csv-badges
branch
from
21c446a
to
ac27aec
Compare
jornh
changed the title
Signed-off-by: jornh <jornhansen@gmail.com>
allisonsuarez
approved these changes
Dec 10, 2020
Signed-off-by: jornh <jornhansen@gmail.com>
Signed-off-by: jornh <jornhansen@gmail.com>
|
All green again |
feng-tao
reviewed
Dec 10, 2020
databuilder/models/badge.py
Outdated
| @@ -18,6 +18,10 @@ def __repr__(self) -> str: | |||
| return 'Badge({!r}, {!r})'.format(self.name, | |||
| self.category) | |||
|
|
|||
| def __eq__(self, other: Any) -> bool: # type: ignore[override] | |||
There was a problem hiding this comment.
Oh yeah of course! Thanks - currently AFK but will change
There was a problem hiding this comment.
Hmm, apart from that it then throws an error
def __eq__(self, other: Badge) -> bool:
E NameError: name 'Badge' is not definedApparently the Class itself isn't know at that point - which I find a little strange. So I'm keeping Any unless you know a trick.
I got rid if the # type: ignore[override] though 🙂
Oh wait, through this i found out it needs to be other: 'Badge' and then mypy itself gives the full recommended way:
❯ mypy .
databuilder/models/badge.py:21: error: Argument 1 of "__eq__" is incompatible with supertype "object"; supertype defines the argument type as "object"
databuilder/models/badge.py:21: note: This violates the Liskov substitution principle
databuilder/models/badge.py:21: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
databuilder/models/badge.py:21: note: It is recommended for "__eq__" to work with arbitrary objects, for example:
databuilder/models/badge.py:21: note: def __eq__(self, other: object) -> bool:
databuilder/models/badge.py:21: note: if not isinstance(other, Badge):
databuilder/models/badge.py:21: note: return NotImplemented
databuilder/models/badge.py:21: note: return <logic to compare two Badge instances>There was a problem hiding this comment.
wow that's so useful
Signed-off-by: jornh <jornhansen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add back badges at
both table andcolumn levels in Quickstart. They were missing since the API change splitting badges and tags introduced as part of metadata and frontend 3.0.0 versionsUpdate: We decided to do the table level handling with what's already merged in #417
Tests
Added testing to CvsTableColumnExtractor of badges at
table andcolumn level.Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test