Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete unused metric models #423

Merged
merged 2 commits into from Dec 9, 2020
Merged

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Dec 9, 2020

Signed-off-by: feng-tao fengtao04@gmail.com

Summary of Changes

We don't use the metric model for dashboard feature. The model was checked-in way before dashboard feature was designed.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: feng-tao <fengtao04@gmail.com>
Signed-off-by: feng-tao <fengtao04@gmail.com>
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! had no idea this existed

@feng-tao feng-tao merged commit ea42c38 into master Dec 9, 2020
@feng-tao feng-tao deleted the tfeng_delete_unused_models branch December 9, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants