Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo in Readme for RedashVisualizationWidget. #424

Merged
merged 1 commit into from Dec 10, 2020

Conversation

damon09273
Copy link
Contributor

@damon09273 damon09273 commented Dec 10, 2020

Summary of Changes

Typo in Readme for RedashVisualizationWidget.
Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@damon09273 damon09273 requested a review from a team as a code owner December 10, 2020 09:51
@feng-tao feng-tao merged commit 29bd72f into amundsen-io:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants